Home » Create users using bash script

Create users using bash script

Solutons:


You appear to have written your script in a word processor that have capitalized words that shouldn’t be capitalized (command names ar case sensitive on Unix), and used fancy typographical double quotes (“...” instead of "..."). Do consider writing your scripts in a simpler text editor such as nano, emacs or vim. The site https://www.shellcheck.net/ is very helpful for spotting simpler errors in scripts.

Take that as a hint that all command names should be lower-case and that you need to change the quotes.

Your loop is also a bit strange. On one hand you seem to want to loop over { $num } (which I don’t know what it means), and on the other you increment num inside the loop. Note that num is the number inputted by the user, so incrementing it makes no sense. Let’s assume that you update the variable in the loop:

number=1
while [ "$num" -ne 0 ]; do
   # code here that increments "number",
   # and conditionally decrements "num"
done

Remember that you have to keep track of the number used in the username as well as the number of created users. You need to do this to know both when you have created the correct number of users, and to be able to skip usernames that are already existing on the system. Here I’m choosing to decrement num until it reaches zero, while keeping the number used in usernames in the variable called number.

Inside the loop, you will have to try to create user $pre$number, and if that succeeds, you decrement num. In each iteration, you then always increment number. You iterate until num reaches zero, which means that you have created all the users.

Assuming that adduser returns a sane exit status for succeeding and failing (note: I’m not a Linux user, so I don’t know what happens on CentOS if you try to create an already existing user), you could add a user using

if adduser -m "$pre$number"; then
    # adduser succeeded, we've created a new user, decrement num
    num=$(( num - 1 ))
fi
number=$(( number + 1 ))

Or, you could check whether the proposed username exists first using getent:

if ! getent passwd "$pre$number" >/dev/null; then
    # the user don't exist, create it
    adduser -m "$pre$number"
    num=$(( num - 1 ))
fi
number=$(( number + 1 ))

The getent passwd command will fail if the given username does not exist on the system. We use this fact here to avoid calling adduser with an existing username.

I’ll ignore most of the code in the beginning of your script, but I’ll just point out that declaring num as integer is not needed, and that read -p 'prompt' var reads a value from the user with a specific prompt, so the echo statements are not needed.

You may also want to consider the fact that the $pre string in your code actually is accepted even though it may not be the string student or user (as the output from you current code suggests that it should be).

You should also account for the case where $pre may be invalid in a username, for example, when it contains a space. Depending on how you write the code, and if you don’t check that $pre$number is as a username, this may mean failing to create any accounts, or trying to create an infinite number of accounts.

Related Solutions

How can I stop applications and services from running?

First Things First You may have some misconceptions about how Android works and what's really happening when a service is running or an app is in the background. See also: Do I really need to install a task manager? Most apps (e.g., ones you launch manually)...

How do I reset a lost administrative password?

By default the first user's account is an administrative account, so if the UI is prompting you for a password it's probably that person's user password. If the user doesn't remember their password you need to reset it. To do this you need to boot into recovery...

How can I use environment variables in Nginx.conf

From the official Nginx docker file: Using environment variables in nginx configuration: Out-of-the-box, Nginx doesn't support using environment variables inside most configuration blocks. But envsubst may be used as a workaround if you need to generate your...

Difference between .bashrc and .bash_profile

Traditionally, when you log into a Unix system, the system would start one program for you. That program is a shell, i.e., a program designed to start other programs. It's a command line shell: you start another program by typing its name. The default shell, a...

Custom query with Castle ActiveRecord

In this case what you want is HqlBasedQuery. Your query will be a projection, so what you'll get back will be an ArrayList of tuples containing the results (the content of each element of the ArrayList will depend on the query, but for more than one value will...

What is the “You have new mail” message in Linux/UNIX?

Where is this mail? It's likely to be in the spool file: /var/mail/$USER or /var/spool/mail/$USER are the most common locations on Linux and BSD. (Other locations are possible – check if $MAIL is set – but by default, the system only informs you about...

How can I find the implementations of Linux kernel system calls?

System calls aren't handled like regular function calls. It takes special code to make the transition from user space to kernel space, basically a bit of inline assembly code injected into your program at the call site. The kernel side code that "catches" the...

Is a composite index also good for queries on the first field?

It certainly is. We discussed that in great detail under this related question: Working of indexes in PostgreSQL Space is allocated in multiples of MAXALIGN, which is typically 8 bytes on a 64-bit OS or (much less common) 4 bytes on a 32-bit OS. If you are not...

Explaining computational complexity theory

Hoooo, doctoral comp flashback. Okay, here goes. We start with the idea of a decision problem, a problem for which an algorithm can always answer "yes" or "no." We also need the idea of two models of computer (Turing machine, really): deterministic and...

Building a multi-level menu for umbraco

First off, no need pass the a parent parameter around. The context will transport this information. Here is the XSL stylesheet that should solve your problem: <!-- update this variable on how deep your menu should be --> <xsl:variable...

How to generate a random string?

My favorite way to do it is by using /dev/urandom together with tr to delete unwanted characters. For instance, to get only digits and letters: tr -dc A-Za-z0-9 </dev/urandom | head -c 13 ; echo '' Alternatively, to include more characters from the OWASP...

How to copy a file from a remote server to a local machine?

The syntax for scp is: If you are on the computer from which you want to send file to a remote computer: scp /file/to/send username@remote:/where/to/put Here the remote can be a FQDN or an IP address. On the other hand if you are on the computer wanting to...

What is the difference between curl and wget?

The main differences are: wget's major strong side compared to curl is its ability to download recursively. wget is command line only. There's no lib or anything, but curl's features are powered by libcurl. curl supports FTP, FTPS, HTTP, HTTPS, SCP, SFTP, TFTP,...

Using ‘sed’ to find and replace [duplicate]

sed is the stream editor, in that you can use | (pipe) to send standard streams (STDIN and STDOUT specifically) through sed and alter them programmatically on the fly, making it a handy tool in the Unix philosophy tradition; but can edit files directly, too,...

How do I loop through only directories in bash?

You can specify a slash at the end to match only directories: for d in */ ; do echo "$d" done If you want to exclude symlinks, use a test to continue the loop if the current entry is a link. You need to remove the trailing slash from the name in order for -L to...

How to clear journalctl

The self maintenance method is to vacuum the logs by size or time. Retain only the past two days: journalctl --vacuum-time=2d Retain only the past 500 MB: journalctl --vacuum-size=500M man journalctl for more information. You don't typically clear the journal...